Code Review for illumos-3027-webrev-2

Prepared by:Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org> on 2012-Jul-23 18:44 +0200 CEST
Workspace:/export/ws/illumos-gate (at d46e95755cd7)}
Compare against: ssh://anonhg@hg.illumos.org/illumos-gate (at 2aba784c276b)
Summary of changes: 19 lines changed: 11 ins; 0 del; 8 mod; 2908 unchg
Patch of changes: illumos-3027-webrev-2.patch
Printable review: illumos-3027-webrev-2.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/common/mboot_extra.c

3027 installgrub can segfault when encountering bogus data on disk
7 lines changed: 6 ins; 0 del; 1 mod; 179 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/common/mboot_extra.h

3027 installgrub can segfault when encountering bogus data on disk
1 line changed: 0 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/installboot/installboot.c

3027 installgrub can segfault when encountering bogus data on disk
5 lines changed: 2 ins; 0 del; 3 mod; 946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/installboot/installboot.h

3027 installgrub can segfault when encountering bogus data on disk
1 line changed: 1 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/installgrub/installgrub.c

3027 installgrub can segfault when encountering bogus data on disk
4 lines changed: 1 ins; 0 del; 3 mod; 1562 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/boot/installgrub/installgrub.h

3027 installgrub can segfault when encountering bogus data on disk
1 line changed: 1 ins; 0 del; 0 mod; 93 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.